deps: bump uart_16550 to 0.8.0 + fix UEFI weirdness - #580
Open
phip1611 wants to merge 4 commits into
Open
Conversation
This reverts commit 313769e.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
To properly use `Uart16550::init()`, we need to have full ownership of the serial device. Otherwise, there is undefined runtime behavior caused by the interaction with the UEFI console driver that also claims ownership of the device. This is needed to replace our own serial logger with the Uart16550Tty type of the uart_16550 crate. It ensures much clearer separations of concerns and ensures this crate can log reliably on a variety of real hardware.
phip1611
changed the title
phip1611
marked this pull request as ready for review
August 16, 2026 16:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the bootloader to
uart_165500.8.0, bringing its modernized, real-hardware-focused UART driver into the project now that the upstream regression is resolved.Alongside the API migration, the UEFI path explicitly disconnects the UEFI console from the serial device before initializing the bootloader logger. This gives the logger exclusive ownership of the UART, preventing conflicting device access and avoiding UEFI console output being duplicated on the serial port.
Some context for some weirdness that @Freax13 found in an earlier PR (#565 (comment)):
Testing
I tested the crate on real hardware (rust-osdev/uart_16550#71) but not the bootloader crate. If you give me instructions for how to test it best without much effort, it would be highly appreciated.